Campaigns objectives endpoint #12616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfano
added
type: task
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
JorgeMucientes
force-pushed
the
issue/12469-campaigns-objectives-endpoint
branch
from
b54f306
to
29424db
Compare
…-endpoint # Conflicts: # build.gradle
JorgeMucientes
removed
the
status: do not merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12616 +/- ##
============================================
- Coverage 40.64% 40.63% -0.01%
Complexity 5673 5673
============================================
Files 1230 1230
Lines 69167 69182 +15
Branches 9579 9580 +1
============================================
Hits 28114 28114
- Misses 38468 38483 +15
Partials 2585 2585 ☔ View full report in Codecov by Sentry. |
JorgeMucientes
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Thanks for working on this @irfano. Changes look good and work as expected. Merging!
JorgeMucientes
deleted the
issue/12469-campaigns-objectives-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #12469
Description
This adds functions to the
BlazeRepositoryfor fetching campaign objectives.I haven't included unit tests since the newly added functions don't have complex logic and act as a gateway to the FluxC library.
Warning
do not merge: FluxC reference should be updated to the trunk hash before merging.
Known issue: Although the
campaigns/objectivesendpoint accepts alocaleparameter, the response is not localized on the API side.Steps to reproduce
Fetching objectives is not yet implemented in the UI. The retrieved data can only be viewed using the Database Inspector. To fetch objectives on the Blaze campaign preview screen, apply this patch: Fetch_objectives.patch
Testing information
The data in the Database inspector should be like this:
The tests that have been performed
I verified the stored data in the
BlazeCampaignObjectivestable.RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: